Replace failing test_invalid_subconfig subtest - #14055
Merged
Merged
Conversation
test_invalid_subconfig began failing due to changes in the environment. Test happened to verify that a validation error is thrown when all directories on the path are unwritable. 1. this is difficult to reproduce in controlled test setup. 2. intuitively one would expect that it is enough for provided directory to be writable, yet check is implemented to verify all directories along the path. Reason for this is unclear. 3. it is unclear if test on purpose used a path with all directories unwritable or if it was an accident. As expected behavior is unknown, create a x-failing replacement test for behavior to be verified in the future.
achaikou
added
the
release-notes:skip
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14055 +/- ##
==========================================
- Coverage 91.85% 91.83% -0.02%
==========================================
Files 481 480 -1
Lines 33342 33337 -5
==========================================
- Hits 30626 30615 -11
- Misses 2716 2722 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
ajaust
approved these changes
Jul 30, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_invalid_subconfigbegan failing due to changes in the environment.Test happened to verify that a validation error is thrown when all directories on the path are unwritable.
As expected behavior is unknown, create a x-failing replacement test for behavior to be verified in the future.
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.